Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default to all ports with SYN scan. #97

Merged
merged 3 commits into from
Aug 9, 2024
Merged

Conversation

3asm
Copy link
Member

@3asm 3asm commented Aug 9, 2024

No description provided.

Copy link
Contributor

@PiranhaSa PiranhaSa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will change the command made so the unittest needs to be updated

nmasdoufi-ol
nmasdoufi-ol previously approved these changes Aug 9, 2024
Copy link

@nmasdoufi-ol nmasdoufi-ol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. need to update the unit test though.

Copy link

codecov bot commented Aug 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.21%. Comparing base (6d1caea) to head (22328a8).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #97      +/-   ##
==========================================
- Coverage   94.46%   94.21%   -0.26%     
==========================================
  Files           9        9              
  Lines         795      795              
==========================================
- Hits          751      749       -2     
- Misses         44       46       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@3asm 3asm merged commit 60e5301 into main Aug 9, 2024
4 of 5 checks passed
@3asm 3asm deleted the fix/swtich_syn_all_port branch August 9, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants